SAP / ui5-tooling

An open and modular toolchain to develop state of the art applications based on the UI5 framework
https://sap.github.io/ui5-tooling
Apache License 2.0
466 stars 71 forks source link

Button: Type="Ghost" (Secondary) has a Different Visual Design in Headers #993

Closed eric-hoffmann-sap closed 3 months ago

eric-hoffmann-sap commented 3 months ago

Expected Behavior

The visual design of buttons using type=“Ghost” is a) consistent and independent of the parent container, and b) according to the visual design specification.

Current Behavior

The visual design of buttons using type=“Ghost” is different depending on the parent container, for example, when placed in a header compared to the content. Open Screen Recording(SAP internal link removed). Bug according to the SAP Fiori for Web team.

Steps to Reproduce the Issue

  1. Open a UI5 Sample
  2. Enter the following code: `<mvc:View xmlns="sap.m" xmlns:mvc="sap.ui.core.mvc" xmlns:core="sap.ui.core" height="100%" controllerName="sap.m.sample.Button.Page"> <Page title="Page" class="sapUiContentPadding" >
    <content>
        <HBox>
            <Button text="Default / Ghost"
                    press="Ghost">
            </Button>
            <Button text="Transparent"
                    type="Transparent">
            </Button>
        </HBox>
    </content>

    </mvc:View>`

Context

d3xter666 commented 3 months ago

Hi @eric-hoffmann-sap ,

Thank you for your feedback! Unfortunately, this repo is meant for ui5-tooling issues only. Please raise your concerns into the respective repository: https://github.com/SAP/openui5

Please, also bare in mind not to expose any sap internal information. Instead you can use the internal channels for that!

Cheers