search

SAP / ui5-typescript

Tooling to enable TypeScript support in SAPUI5/OpenUI5 projects
https://sap.github.io/ui5-typescript
Apache License 2.0
201 stars 28 forks source link

ts-types-esm sap.ui.core.format.NumberFormat.getScale #339

Closed nlunets closed 2 years ago

nlunets commented 2 years ago

This method is a relatively public one considering the naming but was not tagged public nor private nor anything and as such is missing.

Shoudn't it be tagged public ?

codeworrior commented 2 years ago

@tobiasso85 and @stopcoder : can you please comment? Is NumberFormat#getScale intended to be public? Wording of the documentation somehow suggests this.

tobiasso85 commented 2 years ago

Yes, indeed it should be public.

tobiasso85 commented 2 years ago

was fixed with: https://github.com/SAP/openui5/commit/ece96e7ee7daa86b3883951a19b7ad5dae187401

akudev commented 2 years ago

Thanks, all!