SAP / ui5-typescript

Tooling to enable TypeScript support in SAPUI5/OpenUI5 projects
https://sap.github.io/ui5-typescript
Apache License 2.0
202 stars 28 forks source link

introduce valueType setting for properties to support @type annotation #457

Closed devtomtom closed 6 months ago

devtomtom commented 6 months ago

The runtime metadata is currently limited to basic types like int, object, any. For example, with Date-based controls, using any in TypeScript is not ideal. Typically, the preferred types are UI5Date or the native Date.

To address this, introducing the valueType property and use it for displaying in the API Reference.

cla-assistant[bot] commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

devtomtom commented 6 months ago

Not needed because we tend to redefine the type property with the content of the @type tag.

BenReim commented 6 months ago

@devtomtom Would this be a solution that applies for the interface generator as well (https://github.com/SAP/ui5-typescript/issues/427) ?