fix: fixed ontouched call

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.

https://ui5-webcomponents-ngx.netlify.app/

Apache License 2.0

23 stars 4 forks source link

fix: fixed ontouched call #110

Closed g-cheishvili closed 5 months ago

g-cheishvili commented 5 months ago

Related Issue(s)

relates to #95

Description

onTouched was called only after the value change, now it is being called after focusOut. This is a temporary measure, as next iteration will change a lot.
Removed the distinctUntilChanged

netlify[bot] commented 5 months ago

Deploy Preview for ui5-webcomponents-ngx failed.

Name	Link
Latest commit	9738730d08e9448e5c5c1d7cc0753376ce0e4c1b
Latest deploy log	https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/659d4e6aa471600008d792b9

markokastelec commented 3 months ago

Hi!

@g-cheishvili: I have a problem probably connected to this change. After upgrade from version 0.2.2 to version 0.2.3 I am getting random errors like this on different components:

Example of the component (in this case combobox) where error happens:

I tried do reinstall packages (deleted node_modules and ran npm install), but errors persist. Do you have any idea how to resolve this? I was googling but didn't find any reports on this topic.

Any response will be greatly appreciated.

KR, Marko

g-cheishvili commented 3 months ago

Very well might be, I noticed that and fixed in new pr, which is open right now