Closed ilhan007 closed 5 months ago
Name | Link |
---|---|
Latest commit | bc7299b6284bf19aa57504067cbbad392bbf63ac |
Latest deploy log | https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/6675aab3bd17b90008d542b9 |
Deploy Preview | https://deploy-preview-134--ui5-webcomponents-ngx.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Prior to this PR the
@ui5/theming-ngx
package was missing from the projects dependencies.Issue Prior to this PR,
ng create my-app
npm install @ui5/webcomponents-ngx
,ng serve
@ui5/theming-ngx
could not be resolved and you need to manually install the@ui5/theming-ngx
package in addition no matter you want or don't need themingMost probably it was optimisation effort to exclude the package and only add the dependency if the app requires theming. However, it's not working fine. Even if we use
ng add @ui5/webcomponents-ngx
the user is not asked to install it and the result is the same - we will get an error onng serve
.Solution Add
@ui5/theming-ngx
as dependency unconditionally to avoid breaking on first steps of the usage.Fixes: https://github.com/SAP/ui5-webcomponents-ngx/issues/62