SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
27 stars 5 forks source link

chore: add '@ui5/theming-ngx' dependency always #134

Closed ilhan007 closed 5 months ago

ilhan007 commented 5 months ago

Prior to this PR the @ui5/theming-ngx package was missing from the projects dependencies.

Issue Prior to this PR,

Most probably it was optimisation effort to exclude the package and only add the dependency if the app requires theming. However, it's not working fine. Even if we use ng add @ui5/webcomponents-ngx the user is not asked to install it and the result is the same - we will get an error on ng serve.

Solution Add @ui5/theming-ngx as dependency unconditionally to avoid breaking on first steps of the usage.

Fixes: https://github.com/SAP/ui5-webcomponents-ngx/issues/62

netlify[bot] commented 5 months ago

Deploy Preview for ui5-webcomponents-ngx ready!

Name Link
Latest commit bc7299b6284bf19aa57504067cbbad392bbf63ac
Latest deploy log https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/6675aab3bd17b90008d542b9
Deploy Preview https://deploy-preview-134--ui5-webcomponents-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.