fix: migration leftovers - Githubissues

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.

https://ui5-webcomponents-ngx.netlify.app/

Apache License 2.0

27 stars 5 forks source link

fix: migration leftovers #142

Closed droshev closed 3 months ago

droshev commented 3 months ago

Related Issue(s)

closes

Description

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation

Visual Testing:

[ ] visual misalignments/updates
[ ] check Light/Dark/HCB/HCW themes
[ ] RTL/LTR - proper rendering and labeling
[ ] responsiveness(resize)
[ ] Content Density (Cozy/Compact/(Condensed))
[ ] States - hover/disabled/focused/active/on click/selected/selected hover/press state
[ ] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
[ ] Mouse vs. Keyboard support
[ ] Text Truncation

API and functional correctness

[ ] check for console logs (warnings, errors)
[ ] API boundary values
[ ] different combinations of components - free style
[ ] change the API values during testing

Documentation and Example validations

[ ] missing API documentation or it is not understandable
[ ] poor examples
[ ] Stackblitz works for all examples

Accessibility testing
Browser Testing - Edge, Safari, Chrome, Firefox

PR Quality

[ ] the commit message(s) follows the guideline: https://github.com/SAP/ui5-webcomponents-ngx/blob/main/CONTRIBUTING.md
[ ] tests for the changes that have been done
[ ] all items on the PR Review Checklist are addressed : https://github.com/SAP/ui5-webcomponents-ngx/wiki/PR-Review-Checklist
[ ] Run npm run build-pack-library and test in external application
[ ] update README.md
[ ] Breaking Changes Wiki

netlify[bot] commented 3 months ago

Deploy Preview for ui5-webcomponents-ngx ready!

Name	Link
Latest commit	d01305823107c849185ba006c65558c0e7dcff8f
Latest deploy log	https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/66b75bc7e6ccec00082adc3a
Deploy Preview	https://deploy-preview-142--ui5-webcomponents-ngx.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.