search

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
27 stars 4 forks source link

Installation does not automatically install package dependancies #29

Closed bpan4 closed 1 year ago

bpan4 commented 1 year ago

Bug Description

When installing the package using the commands "npm install @ui5/webcomponents-ngx" and "ng add @ui5/webcomponents-ngx", the following packages are not automatically installed:

  1. @ui5/webcomponents-fiori
  2. @ui5/webcomponents
  3. @ui5/webcomponents-base

The project cannot be started until the user manually installs all the above packages.

Expected Behavior

The commands "npm install @ui5/webcomponents-ngx" and "ng add @ui5/webcomponents-ngx" should install the following packages:

  1. @ui5/webcomponents-ngx
  2. @ui5/webcomponents-fiori
  3. @ui5/webcomponents
  4. @ui5/webcomponents-base

Steps to Reproduce

  1. Create a new Angular project using the command "ng new "
  2. Run the command "npm install @ui5/webcomponents-ngx" OR "ng add @ui5/webcomponents-ngx"
  3. Run the command "npm install @ui5/theming-ngx" OR "ng add @ui5/theming-ngx"
  4. Create ui5 component(s) in app.component.html with valid properties and values, ex. ui5-shellbar
  5. Add "import { Ui5AngularModule } from '@ui5/webcomponents-ngx';" in app.module.ts
  6. Add "Ui5AngularModule" to @NgModule.imports in app.module.ts
  7. Attempt to start the project using the command "npm run start" OR "ng serve"
  8. See errors in command line

Context

Log Output / Stack Trace / Screenshots

Example of errors: ./node_modules/@ui5/webcomponents-ngx/fesm2020/ui5-webcomponents-ngx.mjs:4:0-46 - Error: Module not found: Error: Can't resolve '@ui5/webcomponents-fiori/dist/Bar.js' in '/Users/I584835/new-angular-proj/mock-project/node_modules/@ui5/webcomponents-ngx/fesm2020'

./node_modules/@ui5/webcomponents-ngx/fesm2020/ui5-webcomponents-ngx.mjs:34:0-43 - Error: Module not found: Error: Can't resolve '@ui5/webcomponents/dist/Avatar.js' in '/Users/I584835/new-angular-proj/mock-project/node_modules/@ui5/webcomponents-ngx/fesm2020'

./node_modules/@ui5/webcomponents-ngx/fesm2020/ui5-webcomponents-ngx.mjs:116:0-72 - Error: Module not found: Error: Can't resolve '@ui5/webcomponents-base/dist/config/Theme.js' in '/Users/I584835/new-angular-proj/mock-project/node_modules/@ui5/webcomponents-ngx/fesm2020'

Priority

github-actions[bot] commented 1 year ago

Hello @bpan4, thank you for using ui5-webcomponents-ngx! The ui5-webcomponents-ngx team will triage your issue as soon as possible.