search

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

Ng-add does not add ui5 theming provider #31

Closed g-cheishvili closed 1 year ago

g-cheishvili commented 1 year ago

Bug Description

When you install the package with ng add and use theming, it should also add theming provider service module in app.module alongside theming module

Expected Behavior

Working theming

N1XUS commented 1 year ago

@g-cheishvili actually, schematics are importing Ui5ThemingModule which contains instance of theming service, so providing the service itself is not needed anymore: https://github.com/SAP/ui5-webcomponents-ngx/blob/main/libs/ui5-angular-theming/src/ui5-theming.module.ts#L15