search

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

Introduce typings for NG WC wrappers #39

Closed fkolar closed 1 year ago

fkolar commented 1 year ago

Feature Request Description

Make NG Wrappers type safe component and utilize as much as we can from Typescript compiler. Usage of any has its place, but we should try avoid this as much as possible.

Proposed Solution

Since we are already on TS 3+, we should at least try to use unknown or TS conditional types that can do allot of magic. There are also callback methods cmp. implements such as onAfterRendering, onBeforeRendering that should return a void

github-actions[bot] commented 1 year ago

Hello @fkolar, thank you for using ui5-webcomponents-ngx! The ui5-webcomponents-ngx team will triage your issue as soon as possible.