SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

Shellbar items cannot be given accessible names #49

Closed bpan4 closed 1 year ago

bpan4 commented 1 year ago

Bug Description

When a ui5-shellbar-item element is used to create a button inside ui5-shellbar, there is no way to set an accessible name for the button that is generated.

Expected Behavior

There should be a way to set an accessible name for ui5-shellbar-item elements.

Steps to Reproduce

  1. Create a ui5-shellbar with at least one ui5-shellbar-item item.
  2. Use either a screen reader or generate a Lighthouse report
  3. Notice that the ui5-shellbar-item item is reported only as a button without an accessible name that would provide more details on the functionality of the button

Isolated Example

<ui5-shellbar primary-title="Airlines" [show-notifications]="true" notifications-count="2">
    <ui5-shellbar-item icon="palette" aria-label="Change themes"></ui5-shellbar-item>
</ui5-shellbar>

Context

Log Output / Stack Trace / Screenshots

image Part of the report generated by Lighthouse. The palette icon is a ui5-shellbar-item in the shellbar.

Priority

g-cheishvili commented 1 year ago

This can not be solved on our end, created ticket on ui5 webcomponents repository

g-cheishvili commented 1 year ago

use ui5-shellbar-item[title] to specify a title for the button. Problem disappears