SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

Progress indicators cannot be given accessible names #50

Closed bpan4 closed 2 weeks ago

bpan4 commented 1 year ago

Bug Description

There is no way to set accessible names for ui5-progress-indicator elements.

Expected Behavior

There should be a way to set an accessible name for ui5-progress-indicator elements.

Steps to Reproduce

  1. Create a ui5-progress-indicator element.
  2. Use either a screen reader or generate a Lighthouse report
  3. Notice that the ui5-progress-indicator item is reported to be without an accessible name that would provide more details on its function

Isolated Example

<ui5-progress-indicator 
   display-value="Late" 
   value-state="Error" 
   [value]="20" 
   aria-label="20% of flights have been late">
</ui5-progress-indicator>

Context

Log Output / Stack Trace / Screenshots

image Part of the report generated by Lighthouse.

Priority

droshev commented 1 year ago

The bug is on ui5-webcomponents once it is fixed there we will get the fixed without any manual changes required in that repo

ilhan007 commented 2 weeks ago

Hello @bpan4 we did not update you timely, but the ProgressIndicator has accessibleName property as requested.

BR, ilhan