search

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

Missing Dependencies #62

Closed gedlbauer closed 1 week ago

gedlbauer commented 1 year ago

Bug Description

The package @ui5/theming-ngx is missing from the projects dependencies. To use @ui5/webcomponents-ngx, you need to manually install the mentioned package.

Expected Behavior

@ui5/theming-ngx should be installed automatically when installing @ui5/webcomponents-ngx

Steps to Reproduce

  1. install @ui5/theming-ngx
  2. try to use it

Context

Priority

droshev commented 1 year ago

@gedlbauer Did you try running ng add @ui5/webcomponents-ngx? Our CLI will do the rest?

ilhan007 commented 2 weeks ago

Hi @g-cheishvili it sill fails, when you get started from scratch with angular17 app and install the -webcomponents-ngx library it fails with missing @ui5/theming-ngx as code imports something from that package but this dependency is never added.

reopening the issue..

ilhan

ilhan007 commented 1 week ago

Hello @gedlbauer with @ui5/webcomponents-ngx 0.3.0-rc.9, you need to only 

npm i @ui5/webcomponents-ngx

and then

ng serve

and everything works without additional steps from your side as the @ui5/theming-ngx is brought along @ui5/webcomponents-ngx

BR, ilhan