search

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
27 stars 4 forks source link

RangeSlider min and max value labels don't update if the respective values change #82

Closed ynnckth closed 3 months ago

ynnckth commented 1 year ago

Bug Description

When using the ui5-range-slider component with dynamic min and max values, the labels of the range slider do not reflect the updated values.

Expected Behaviour

If I bind the input properties "min" and "max" of the range slider to properties that change dynamically, the labels of the range slider should reflect the new min and max values. However, the labels don't change and keep the initial values instead.

Steps to Reproduce

Create a component containing a ui5-range-slider element. Add two properties minValue and maxValue of type number to your component. Reference these values in the range slider such as <ui5-range-slider [min]="minValue" [max]="maxValue" ...></ui5-range-slider> Add for example a button that increments minValue and maxValue of your component. Observe that the labels of the range slider do not update to reflect the new minimum and maximum range values.

Minimal example sandbox:

https://codesandbox.io/p/sandbox/affectionate-poitras-7pv7vy

Context: UI5 Web Components for Angular version: 0.2.2 Angular Version: 16 OS/Platform: MacOS Browser: Chrome Affected component: ui5-range-slider

github-actions[bot] commented 1 year ago

Hello @ynnckth, thank you for using ui5-webcomponents-ngx! The ui5-webcomponents-ngx team will triage your issue as soon as possible.

veith commented 1 year ago

Look at issue https://github.com/SAP/ui5-webcomponents/issues/7628 this will solve your problem.

ilhan007 commented 3 months ago

Hello @ynnckth this is fixed last year, however we did not update you timely, sorry for that. The issue with the RangeSlider is resolved - tested with 0.3.0-rc.8.