SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

Select: No FormControl support #93

Closed ilhan007 closed 5 months ago

ilhan007 commented 8 months ago

Created the issue on behalf of SAP Build Process Automation: Select - FormControl support is missing.

Expected Behavior

Steps to Reproduce

  1. Go to '...'
  2. ...
  3. ...

Isolated Example

Context

Log Output / Stack Trace / Screenshots

{...}

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

ilhan007 commented 8 months ago

Hello @droshev this is one of the latest issues raised. Meanwhile I will ask the authors for more information. Thank you.

timogeib commented 7 months ago

FormControl not working at all -> No value accessor for form control error in console image image

ilhan007 commented 7 months ago

Hello @mikerodonnell89 @g-cheishvili

The FormControl support of the Select directive should be fixed if you update the ui5-webcomponents-ngx wrappers to the latest ui5-webcomponents as in the latest version we introduced a "value" property to the Select web component (that is marked as formProperty), so that the generated wrapper will extend GVA and the default setters and getters that rely on having a "value" property will work as we added "value" property to the Select web component

Actually I tried to update but there are some build issues to fix: https://github.com/SAP/ui5-webcomponents-ngx/pull/103