search

SAP / ui5-webcomponents-ngx

UI5 Web Components for Angular provides directives for each UI5 Web Component. The directives allow to easily build your Angular application following the SAP Design System.
https://ui5-webcomponents-ngx.netlify.app/
Apache License 2.0
23 stars 4 forks source link

[Title]: No exported type for headerLevelTypes (H1, H2, …) #97

Closed ilhan007 closed 7 months ago

ilhan007 commented 8 months ago

Feature Request Description

Title: No exported type for headerLevelTypes (H1, H2, …)

Proposed Solution

Export types that are available in @ui5/webcomponents/dsit/types and @ui5/webcomponents-fiori/dsit/types

g-cheishvili commented 8 months ago

I tested the Angular directive, without generated type(using the Title directly from the ui5) and found that language server struggles to understand that the TitleLevel contains those heading types and recognizes it as any on HTML side, on the typescript class side, it works as expected. So I think leaving the generated ones for now is better. Hoping it's fixed in ng17

ilhan007 commented 7 months ago

Hello @timogeib please consider the answer by Giorgi above

timogeib commented 7 months ago

@ilhan007 importing the TitleTypes woks fine. Thank you for clarification. Issue is resolved for me. :-)