SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
443 stars 99 forks source link

[SF][OverflowPopover] When placing buttons in the Overflow make sure their content is left-aligned #2393

Closed i323808 closed 2 years ago

i323808 commented 2 years ago

Bug Description

According to https://wiki.wdf.sap.corp/wiki/display/visualcore/OverflowToolbar+%28Fiori+3%29+-+Popover, please make sure buttons in the overflow menu are left-aligned. Here is the original JIRA ticket: https://jira.successfactors.com/browse/WEF-20085.

Expected Behavior

https://wiki.wdf.sap.corp/wiki/display/visualcore/OverflowToolbar+%28Fiori+3%29+-+Popover#OverflowToolbar(Fiori3)Popover-LookandFeel

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--default-story
  2. Shrink the screen
  3. ui5-wc

Context

Log Output / Stack Trace / Screenshots

{...}

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

terezamch commented 2 years ago

Hi @MarcusNotheis ,

The VD spec about the OverflowToolbar says that the components in the overflow must be left aligned. In the classing UI5 this is done by overstyling the styles of the components in the overflow by the OverflowToolbar.

Could you please check if this should be done from your side or we should help somehow?

Thanks in advance, Tereza

MarcusNotheis commented 2 years ago

Yes, this looks like an issue on our side, I'll pull this issue over to our repo :)

MarcusNotheis commented 2 years ago

Released in v0.131.27

ui5-webcomponents-react-bot commented 2 years ago

:tada: This issue has been resolved in version v0.20.3 :tada:

The release is available on v0.20.3

Your semantic-release bot :package::rocket: