search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
452 stars 102 forks source link

FilterBar: missing accessibility properties for filterGroupItem #3573

Open nidhi0104 opened 2 years ago

nidhi0104 commented 2 years ago

Describe the bug Screen renders don't read "required" for the fields that are enabled required.

Isolated Example UI Link Refer: https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-filterbar--default-story

To Reproduce Steps to reproduce the behavior:

  1. Set property 'required' of filterGroupItem as true.
  2. Asterik(*) will come for the first filterGroupItem
  3. The screen render don't read out the 'required' word

Expected behavior It should read out 'required' if some field is set as required

UI5 Web Components for React Information @ui5/webcomponents version:1.6.0 @ui5/webcomponents-react version:0.27.5 Operating System:macOs Browser:chrome

Lukas742 commented 2 years ago

Hi @nidhi0104

we're currently blocked to implement this on our end, as not all ui5 web components do yet support the required attribute. I've created issues regarding this in their repository (e.g. https://github.com/SAP/ui5-webcomponents/issues/5895) Until then you can just add required to the input you pass as child to the FilterGroupItem (if it's supported).

E.g.:

<FilterGroupItem required label="Filter 1">
  <Input required />
</FilterGroupItem>