search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
426 stars 94 forks source link

VariantManagement: Mismatch favorite views behavior with Fiori Guidelines #4992

Closed FRicardi closed 10 months ago

FRicardi commented 10 months ago

Describe the bug

As per Fiori Guidelines states: "f more than 10 favorite views exist, a search option is displayed". On ui5-webcomponents-react implementation, it checks only if there's over 9 Variants. So, whenever we have exactly 10 variants, we have a different behavior than what is expected on Fiori Guidelines. Also, inside manage views should have the search box only over than 10 views. image image

Isolated Example

https://codesandbox.io/s/variant-managent-test-vxy65q?file=/src/App.js

Reproduction steps

  1. Create a Variant Management component
  2. Add 10 variant items
  3. Open the variant popover
  4. See that the search box appears
  5. Open the manage views
  6. See that the search box appears ``

Expected Behaviour

It should not show the search box when there's exactly 10 variants. Source: https://experience.sap.com/fiori-design-web/variant-management/#favorite-views

Screenshots or Videos

image image

UI5 Web Components for React Version

1.7.3

UI5 Web Components Version

1.9.3

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Declaration

Lukas742 commented 10 months ago

Hi @FRicardi

the linked PR will fix the issue with the search input inside the view list popover.

Also, inside manage views should have the search box only over than 10 views.

I didn't find specs for this and SAPUI5 seems to also always show the input there:

image

https://sapui5.hana.ondemand.com/#/entity/sap.ui.comp.smartfilterbar.SmartFilterBar/sample/sap.ui.comp.sample.smartfilterbar.Basic

FRicardi commented 10 months ago

fix(VariantManagement): show search in view list popover if count is over 10 #4999

That makes sense @Lukas742 ! I've read it again and I see that it only refers to the variant list on the popover itself. Thanks a lot for the quick response and fix!

github-actions[bot] commented 10 months ago

:tada: This issue has been resolved in version v1.19.0 :tada:

The release is available on v1.19.0

Your semantic-release bot :package::rocket: