SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
435 stars 97 forks source link

VariantManagement: Custom Input Validation for Variant Names not working properly #5047

Closed knandan15 closed 11 months ago

knandan15 commented 1 year ago

Describe the bug

In the framework component of VariantManagement, we can change the name of the variants from the Manage Views. In the provided example, I have set a condition that a Variant name should be less than 15 characters. When any variant from the list of variants in the Manage Views is renamed as such (>15 characters), it shows Error in that variant, but on clicking "Cancel" and again opening the Manage Views/ Save View, the errors are still persisting.

Isolated Example

https://codesandbox.io/s/variantmanagement-name-validation-forked-cszxss?file=/src/App.js

Reproduction steps

  1. Click on the "Save As" or "Manage" button.
  2. Rename the variant to have more than 15 characters so it will show the error message in the error strip.
  3. Now keep it as it is and click on "Cancel" button.
  4. Open Save As/ Manage views again.

The error messages are still displayed.

Expected Behaviour

Ideally, once we click on Cancel button, things should revert back to the initial scenario before editing. I found that in documentation, no explicit control/event listener was there for Cancel button.

Screenshots or Videos

No response

UI5 Web Components for React Version

1.16.3

UI5 Web Components Version

1.14

Browser

Chrome, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

knandan15 commented 12 months ago

Hi @Lukas742 , Any updates on this issue?

knandan15 commented 11 months ago

Any updates over the issue?

github-actions[bot] commented 11 months ago

:tada: This issue has been resolved in version v1.21.0 :tada:

The release is available on v1.21.0

Your semantic-release bot :package::rocket: