search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
435 stars 97 forks source link

UI5 Webcomponents React version upgrade: [Button] design = Emphasized #5228

Closed lirazhayatSap closed 9 months ago

lirazhayatSap commented 10 months ago

Describe the bug

After upgrading UI5Web components React to 1.20.2 and UI5 Webcomponents to 1.18.0, buttons with design="Emphasized" are displayed incorrectly. background is white, and font color it white as well, causing it to be blank. attached a screenshot.

Isolated Example

https://codesandbox.io/s/compassionate-waterfall-d84w6k

Reproduction steps

  1. create component Bar 2.add button with design="Emphasized" inside
  2. upgrate to components React to 1.20.2 and UI5 Webcomponents to 1.18.0
  3. button text disappeared

Expected Behaviour

Button stays with same design as before the upgrade.

Screenshots or Videos

Screenshot 2023-11-09 at 13 03 50

UI5 Web Components for React Version

1.20.2

UI5 Web Components Version

1.18.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

Lukas742 commented 10 months ago

Hi @lirazhayatSap

your codeSandbox example only shows our default template. Did you forget to save it? Also, there is no version 1.20.2 of @ui5/webcomponents-react.

I've created a codeSandbox using v1.21.2 and tested the described behavior in both sap_horizon and sap_fiori_3(Quartz) theme but wasn't able to reproduce it. So please update your or my example to show the issue.

lirazhayatSap commented 9 months ago

Thank you for your detailed answer, we have found an inner problem.