Closed gnseo closed 9 months ago
Hi @gnseo
this is by design, since there is no representation for the "None" type of the MessageItems
neither. The linked PR will add a note about it to the type
prop.
@Lukas742 :
I think "None" and "Information" should be different, and we can see as above image, there are already different colors for the each of two types by design.
Hi @gnseo
I noticed, that we need to update some styles of the MessageViewButton
component, but the colors are correct. As the MessageItem
basically only has four colors (type
) the MessageViewButton
also only has four colors (type
).
It's the same for the the SAP/OpenUI5 ButtonType
, Critical
, Negative
, Neutral
, and Success
are the four available types for MessageViews. We will deprecate our component, once the ui5-button
(Button
) also allows these types.
I just realized, that we still use the Neutral
colors there for the Information
types. The linked PR will fix this.
:tada: This issue has been resolved in version v1.23.0 :tada:
The release is available on v1.23.0
Your semantic-release bot :package::rocket:
Describe the bug
There are specific colors for "Information" Type, but the "Information" is treated as "None" in
MessageViewButton
.Theming Parameters: https://sap.github.io/ui5-webcomponents-react/iframe.html?viewMode=docs&id=knowledge-base-public-utils--docs#theming-parameters
At the below code, I think we should add following lines for "Information" Type. https://github.com/SAP/ui5-webcomponents-react/blob/6e7002d79826c8bb413406f244013a78f873b113/packages/main/src/components/MessageViewButton/index.tsx#L28C27-L28C27
Isolated Example
No response
Reproduction steps
Expected Behaviour
Screenshot of expected output:
Screenshots or Videos
No response
UI5 Web Components for React Version
1.22.0
UI5 Web Components Version
1.19.0
Browser
Chrome
Operating System
No response
Additional Context
No response
Relevant log output
No response
Declaration