SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
435 stars 97 forks source link

[MessageViewButton]: "Information" and "None" are styled with same colors #5297

Closed gnseo closed 9 months ago

gnseo commented 9 months ago

Describe the bug

There are specific colors for "Information" Type, but the "Information" is treated as "None" in MessageViewButton.

Theming Parameters: https://sap.github.io/ui5-webcomponents-react/iframe.html?viewMode=docs&id=knowledge-base-public-utils--docs#theming-parameters

At the below code, I think we should add following lines for "Information" Type. https://github.com/SAP/ui5-webcomponents-react/blob/6e7002d79826c8bb413406f244013a78f873b113/packages/main/src/components/MessageViewButton/index.tsx#L28C27-L28C27

    case ValueState.Information:
      cssType = 'Information';
      break;

Isolated Example

No response

Reproduction steps

<MessageViewButton
        type={ValueState.Information}
/>

Expected Behaviour

Screenshot of expected output:

Screenshot 2023-12-01 at 14 28 04

Screenshots or Videos

No response

UI5 Web Components for React Version

1.22.0

UI5 Web Components Version

1.19.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

Lukas742 commented 9 months ago

Hi @gnseo

this is by design, since there is no representation for the "None" type of the MessageItems neither. The linked PR will add a note about it to the type prop.

gnseo commented 9 months ago

@Lukas742 :

Screenshot 2023-12-01 at 22 32 27

I think "None" and "Information" should be different, and we can see as above image, there are already different colors for the each of two types by design.

Lukas742 commented 9 months ago

Hi @gnseo

I noticed, that we need to update some styles of the MessageViewButton component, but the colors are correct. As the MessageItem basically only has four colors (type) the MessageViewButton also only has four colors (type).

It's the same for the the SAP/OpenUI5 ButtonType, Critical, Negative, Neutral, and Success are the four available types for MessageViews. We will deprecate our component, once the ui5-button (Button) also allows these types.

Lukas742 commented 9 months ago

I just realized, that we still use the Neutral colors there for the Information types. The linked PR will fix this.

github-actions[bot] commented 9 months ago

:tada: This issue has been resolved in version v1.23.0 :tada:

The release is available on v1.23.0

Your semantic-release bot :package::rocket: