search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
442 stars 99 forks source link

AnalyticalTable | a11y : For AnalyticalTable Focus is coming for non-interactive Empty Text #5467

Closed yoganjan closed 9 months ago

yoganjan commented 9 months ago

Bug Description

For AnalyticalTable , When we are tabbing using keyboard, we see that focus is coming for non interactive empty box .

image

Affected Component

AnalyticalTable

Expected Behaviour

Focus should not be coming for empty box

Isolated Example

No response

Steps to Reproduce

  1. Login https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-analyticaltable--docs
  2. Using Tab key of the keyboard, try to focus the Header column
  3. Observe that the focus is coming for empty box

  4. ...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP

Declaration

Lukas742 commented 9 months ago

Thanks for reporting! I'll forward this issue to the UI5 Web Components for React repo as the affected component is developed there.

Lukas742 commented 9 months ago

Hi @yoganjan

the linked PR will fix the issue, that when you initially tab into the table, the first cell regardless of the content is selected. After the PR has been merged and released, it is now always the first cell with content, i.e. the "Name" cell in your screenshot, that is focused.

Although, the empty select-all cell will still be focusable. The cell is still inside a table and omitting it would create discrepancies between other SAP/OpenUI5 table, where the behavior is the same. (E.g. see here) Also, I would find it strange if a cell is skipped, especially when using screen readers.

ui5-webcomponents-react-bot commented 9 months ago

:tada: This issue has been resolved in version v1.25.0 :tada:

The release is available on v1.25.0

Your semantic-release bot :package::rocket: