SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
443 stars 99 forks source link

[Form]: padding-block-end on label makes it hard to see label and value as a unit #5603

Closed rchrdchn closed 7 months ago

rchrdchn commented 8 months ago

Describe the bug

It makes it hard to see label and value as a unit when the form labelSpan(X) is set to 12 (label and value are stacked on top of each other).

With padding-block-end: 0.25rem SCR-20240313-krdo

Without padding-block-end: 0.25rem SCR-20240313-krjb

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-form--docs

Reproduction steps

  1. go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-form--docs
  2. change the labelSpan(X) props to 12
  3. label and value stack vertically
  4. visually, there is almost equal amount of padding in the bottom of the label and value that makes hard to see as label and value are a unit

Expected Behaviour

visually, label and value should looks like they are a unit.

SCR-20240313-krjb

Screenshots or Videos

label-value-vertical-spacing

UI5 Web Components for React Version

v1.26.0

UI5 Web Components Version

1.19.1

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

rchrdchn commented 7 months ago

Reference to a new web component: https://github.com/SAP/ui5-webcomponents/pull/8281

ui5-webcomponents-react-bot commented 7 months ago

:tada: This issue has been resolved in version v1.27.0 :tada:

The release is available on v1.27.0

Your semantic-release bot :package::rocket: