search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
437 stars 98 forks source link

[ui5-dynamicpage]: header collapse/expand and pin/unpin not announced by screenreader #5666

Closed ee92 closed 5 months ago

ee92 commented 5 months ago

Bug Description

The button label is read but the state change is not announced to screenreader users when they expand/collapse or pin/unpin the page header

Affected Component

ui5-dynamicpage

Expected Behaviour

Expect the state change to be announced

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--docs

Steps to Reproduce

  1. Using a screenreader (JAWS, NVDA, VoiceOver) toggle the the expand and pin buttons and notice the button label is read out but the state change is not announced

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.23.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

ilhan007 commented 5 months ago

Hi @ee92 and colleagues, the Dynamic Page belongs to this repo, thus transferring the issue.

Lukas742 commented 5 months ago

Hi @ee92

thanks for reporting!

The linked PR will fix the issue with the expand button, but for the pin button the behavior is already implemented according to specs:

https://github.com/SAP/ui5-webcomponents-react/assets/9749730/81882553-b917-49ef-ab7a-724f86f11e38

ui5-webcomponents-react-bot commented 5 months ago

:tada: This issue has been resolved in version v1.28.0 :tada:

The release is available on v1.28.0

Your semantic-release bot :package::rocket: