DynamicPage: Toggled state of pin header button not evident to sighted users - Githubissues

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience

https://sap.github.io/ui5-webcomponents-react/

Apache License 2.0

437 stars 98 forks source link

DynamicPage: Toggled state of pin header button not evident to sighted users #5669

Closed ee92 closed 5 months ago

ee92 commented 5 months ago

Describe the bug

The pin icon does not change when toggled, like it does in the SAPUI5

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--docs

Reproduction steps

go to playground and toggle the header pin button, to see the icon doesn't change

Expected Behaviour

Icon should toggle between solid/outline

Screenshots or Videos

SAPUI5

UI5-webcomponents-react Screenshot 2024-04-04 at 9 39 45 AM

UI5 Web Components for React Version

1.23.0

UI5 Web Components Version

1.20.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

[X] I’m not disclosing any internal or sensitive information.

ui5-webcomponents-react-bot commented 5 months ago

:tada: This issue has been resolved in version v1.28.0 :tada:

The release is available on v1.28.0

Your semantic-release bot :package::rocket: