DynamicPage: Navigation region not suitable for the collapse icon & pin header button in object header - Githubissues

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience

https://sap.github.io/ui5-webcomponents-react/

Apache License 2.0

437 stars 98 forks source link

DynamicPage: Navigation region not suitable for the collapse icon & pin header button in object header #5670

Closed ee92 closed 5 months ago

ee92 commented 5 months ago

Describe the bug

The collapse and pin toggle buttons are in a region with role="navigation", which is is misleading to screenreader users

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--docs

Reproduction steps

in the playground open the devtools and look for "DynamicPageAnchorBar" in the DOM. Notice it has attribute role="navigation"

Expected Behaviour

role="navigation" should not be present on the element

Screenshots or Videos

No response

UI5 Web Components for React Version

1.23.0

UI5 Web Components Version

1.20.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

[X] I’m not disclosing any internal or sensitive information.

ui5-webcomponents-react-bot commented 5 months ago

:tada: This issue has been resolved in version v1.28.0 :tada:

The release is available on v1.28.0

Your semantic-release bot :package::rocket: