SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
426 stars 94 forks source link

[VariantManagement]: Improper error thrown while trying to rename the variant name #5766

Closed pppwr7 closed 1 month ago

pppwr7 commented 2 months ago

Describe the bug

In Manage Views Dialog, lets say I change the name of the variant 'Standard1' to 'Standard2' and then back to 'Standard1' , I get the error message 'The view name already exists. Please enter a different name'. I believe, if the name of the variant is changed back to original one, it should not give any error.

Isolated Example

No response

Reproduction steps

  1. open storybook link https://sap.github.io/ui5-webcomponents-react/?path=/story/inputs-variantmanagement--default
  2. open Manage Views dialog.
  3. Change the name of the variant and revert back the change without saving it
  4. Error message is seen

Expected Behaviour

error message should not be shown if the name is same as original one

Screenshots or Videos

image

UI5 Web Components for React Version

1.28.0

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

ui5-webcomponents-react-bot commented 1 month ago

:tada: This issue has been resolved in version v1.28.2 :tada:

The release is available on v1.28.2

Your semantic-release bot :package::rocket: