SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
426 stars 94 forks source link

[ObjectPage]: support the DynamicSideContent component inside the ObjectPage component. #5789

Closed bomasap closed 1 month ago

bomasap commented 2 months ago

Describe the bug

We currently need to add a side panel within the ObjectPage component. However, when the dynamicSideContent is added as content of the ObjectPage, there are no tab actions in the ObjectPage header.

Isolated Example

ObjectPage DynamicSideContent

Reproduction steps

  1. Add dynamicSideContent inside the ObjectPage component as content.
  2. Add some ObjectPageSection as dynamicSideContent Main content
  3. The tabs are not displayed in the Object header area.

Expected Behaviour

The tab actions should be in the ObjectPage Header.

Screenshots or Videos

image

UI5 Web Components for React Version

1.27.0

UI5 Web Components Version

1.24.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

sf

Declaration

Lukas742 commented 1 month ago

Hi @bomasap

the ObjectPage only accepts children of type ObjectPageSectionType, so if you're using DynamicSideContent as direct child of the component this is not supported. Otherwise, please add a reproducible example by using this StackBlitz template.

bomasap commented 1 month ago

Hi @Lukas742

Here is StackBlitz and reproduce this issue. https://stackblitz.com/edit/github-zwueh7?file=src%2FApp.tsx

bomasap commented 1 month ago

Hi @Lukas742 Thank you for confirming the current limitations of DynamicSideContent. Given this, I would like to proceed with submitting a feature request to explore the possibility of extending its capabilities to meet our needs. I appreciate any guidance on the best way to submit this request.

Additionally, if there are alternative approaches or workarounds that could temporarily fulfill our requirements, I would be grateful for any suggestions. Our goal is to integrate DynamicSideContent as a child of ObjectPage, and any advice on how we might achieve this, even indirectly, would be very helpful.

image

Lukas742 commented 1 month ago

Hi @bomasap

I couldn't find any specifications for this in our UX or accessibility guidelines. Additionally, supporting this feature would require a complete refactoring of the ObjectPage. Therefore, we unfortunately have to decline this feature request.

If there are existing specifications for a11y, UX, and design, please guide me to the relevant resources (Please contact me internally if this is the case). Otherwise, consider submitting a request to the central design team and provide the Jira ID here. Should this topic be approved and specifications become available, we will reassess this request.

In my opinion, your best option to get this delivered timely is implementing it yourself though. You can probably use the DynamicPage with a sticky TabContainer as subheader and then define the desired content and scroll behavior yourself.