search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
444 stars 100 forks source link

[FlexBox]: FlexBox will unexpectedly remove stylesheet. #5882

Closed allen138 closed 5 months ago

allen138 commented 5 months ago

Describe the bug

Similar to, https://github.com/SAP/ui5-webcomponents-react/issues/5730, The flexbox component relies on CSS styles generated via useStylesheet, FlexBox/index.tsx#L71. But when one or more instances are on the page, when the component unmounts, the flexbox remaining will lose all styles. I presume the solution in #5730 will be the same here. But consider doing this for all components that use the constructed stylesheets.

Thanks!

Isolated Example

No response

Reproduction steps

Its a little hard to reproduce this in a single core template like a stackblitz. If you need to replicate it, please reach out in our private slack channel for the environment details.

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

main

UI5 Web Components Version

main

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SF

Declaration

MarcusNotheis commented 5 months ago

As discussed via Slack, please try to update to 1.28.4 which should solve the issue.

MarcusNotheis commented 5 months ago

Closing the issue, resolved via Slack.