SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
426 stars 94 forks source link

[AnalyticalTable]: [In entire application for ‘XX’ column header within ‘XX’ table, 4 sided borders are not properly visible, it is visible in dotted border for the users and when we selecting any header row only 3 sided border are visible.] #5898

Closed jadhavarjun closed 3 weeks ago

jadhavarjun commented 1 month ago

Describe the bug

In entire application for ‘XX’ column header within ‘XX’ table, 4 sided borders are not properly visible, it is visible in dotted border for the users and when we selecting any header row only 3 sided border are visible.

Link: https://sap.github.io/ui5-webcomponents-react/?path=/story/data-display-analyticaltable--default&args=sortable:!false;filterable:!false;groupable:!false&globals=theme:sap_horizon_hcb

Reproduction steps:

  1. After clicking on link choose Horizon High Contrast Black/Horizon High Contrast White Theme
  2. Click on any table row data you will able to see the selected that selected text 4 sided borders are not properly visible, it is visible in dotted border.

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

User should be able to see 4-sided borders for the UIs and the focus should be strong for all the corners.

Screenshots or Videos

image

UI5 Web Components for React Version

^1.16.3

UI5 Web Components Version

^1.14.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

jadhavarjun commented 3 weeks ago

Hi @Lukas742,

As you merged the PR (#5944 ) but the issue is still not resolved, Still 4 sided borders are not properly visible, it is visible in dotted border.

Expected behavior: User should be able to see 4-sided borders for the UIs and the focus should be strong for all the corners.

border issue 1
Lukas742 commented 3 weeks ago

Hi @jadhavarjun

merging a PR only means that the commit made it's way to our codebase, not that it has been published. So, the fix will only be available with our next release.

sanjayC5373903 commented 2 weeks ago

Hi @Lukas742 Could you please let me know when it will next release. and after release what should necessary changes we need to do from our site.

Lukas742 commented 2 weeks ago

Hi @sanjayC5373903

we will most likely release a new version tomorrow or early next week. Since this is only a bug fix, all you need to do is update your dependencies. :)

Lukas742 commented 2 weeks ago

🎉 This issue has been resolved in version v1.29.3 🎉

The release is available on v1.29.3

ui5-webcomponents-react-bot commented 5 days ago

:tada: This issue has been resolved in version v2.0.0-rc.0 :tada:

The release is available on v2.0.0-rc.0

Your semantic-release bot :package::rocket: