SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
426 stars 94 forks source link

Filter-bar : Screen reader should convey ‘Checked’ information for the checked checkbox and ‘Unchecked’ information for the unchecked checkbox both the information should be avoided[Component Name]: [Bug Description] #5982

Open sanjayC5373903 opened 5 days ago

sanjayC5373903 commented 5 days ago

Describe the bug

In entire application while navigating around the checkboxes within ‘Filters’ dialog, both ‘Checked and unchecked’ information is being read. Screen reader is not working correctly.

Picture2

<S.FilterBar filterBarExpanded showGoOnFB showClearOnFB onRestore={onFilterBarRestore} useToolbar={useToolbar} showFilterConfiguration={showFilterConfiguration} onGo={onGo} showRestoreButton={showRestoreButton} onClear={onClear} data-testid="FilterBarComp" filterContainerWidth="17rem" className="sapUiSizeCompact" onFiltersDialogSave={e => handleOnFiltersDialogSave(e, onFilterConfigDialogSave)} onFiltersDialogCancel={onFiltersDialogCancel} onFiltersDialogOpen={e => handleOnFiltersDialogOpen(e, onFilterConfigDialogOpen)} onFiltersDialogSelectionChange={onFiltersDialogSelectionChange} variants={
<VariantManagementField variantList={variantList} updateVariantId={updateVariantId} currentVariant={currentVariant} isVariantDirty={isVariantDirty} onSaveManageView={onSaveManageView} handleVariantCreate={handleVariantCreate} handleVariantEdit={handleVariantEdit} triggerDataFetch={triggerDataFetch} variantId={variantId} triggerVariantDetailFetch={triggerVariantDetailFetch} /> }

{filterFieldsList.map( ({ key, fieldKey, label, groupName, labelTooltip, required, visibleInFilterBar, enabled = true, considerGroupName, ...filter }) => ( <FilterGroupItem key={key} label={label} groupName={groupName} labelTooltip={labelTooltip} required={required} considerGroupName={considerGroupName} data-testid="FilterGroupItemComp" visibleInFilterBar={enabled}

<FilterField label={label} key={key} fieldKey={fieldKey} {...filter} required={required} inputDataset={filterDataset} customOnChangeHandler={onChange} onPageFilterBarGoOnEnter={onPageFilterBarGoOnEnter} onGo={onGo} /> ), )}

</S.FilterBar>

------------------------------------------------------------------------------
import React, { forwardRef } from 'react';

const FilterField = forwardRef(({ as: FilterFieldComponent, ...props }, ref) => { return <FilterFieldComponent {...props} />; });

export default FilterField;

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

Screen reader should convey ‘Checked’ information for the checked checkbox and ‘Unchecked’ information for the unchecked checkbox both the information should be avoided.

Screenshots or Videos

No response

UI5 Web Components for React Version

0.27.5

UI5 Web Components Version

1.6.0

Browser

Chrome

Operating System

Windows11

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 5 days ago

Hi @sanjayC5373903

v0.27.5 was still in beta state and is over 2 years old. Since I can't reproduce the issue and the FilterBar has changed a lot since then please retest the issue with the latest version of @ui5/webcomponents-react.