SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
435 stars 97 forks source link

[RadioButton && Label]: [While navigating around most of the button & radio button within ‘XX’ dialogs, names & group names are not associated with the respective UIs.] #6112

Closed sanjayC5373903 closed 5 days ago

sanjayC5373903 commented 1 month ago

Describe the bug

  1. While navigating around most of the radio button within ‘XX’ dialogs, group names are not associated with the respective UIs. Screenshot 2024-07-24 102107
{ setSelected('demandDriven'); setValue('strategyGroup', 'demandDriven'); }} disabled={checkFormView(formType)} data-testid="demandDriven" />

DialogFormField component return part below.

<S.DialogFormFieldFlexBox direction={direction}> {label && (labelStyle ? ( <S.Label required={required} direction={direction} showColon={colon} style={labelStyle}> {label} </S.Label> ) : ( <S.Label required={required} direction={direction} showColon={colon}> {label} </S.Label> ))} {FormElement && (

  )}
</S.DialogFormFieldFlexBox>
  1. While navigating around most of the buttons within ‘XX’ dialogs, names are not associated with the respective UIs. Screenshot 2024-07-24 102045

<FlexBox justifyContent="SpaceBetween" alignItems="Baseline" style={{ marginBottom: '0.5rem' }}

<Label required style={{ margin: '0.1875rem 0' }} showColon={true}> {t('SHELF_LIFE_RANGE')}

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

Every name and their respective group names should be associated together and should be read by the screen reader.

Screenshots or Videos

No response

UI5 Web Components for React Version

^1.16.3

UI5 Web Components Version

^1.14.0

Browser

Chrome

Operating System

Windows11

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

MarcusNotheis commented 1 month ago

Hi @sanjayC5373903,

please add a reproducible example, preferably by using our Stackblitz Template. Your current sample contains custom components and libraries from your project, hence we can't use it for testing purposes.

sanjayC5373903 commented 1 month ago

Hi @MarcusNotheis Thanks for response. Example https://stackblitz.com/edit/github-i6cvg6?file=src%2FApp.tsx,src%2FRadioBtnGrpFile.tsx

As above url of code has below version and its working fine, its read the respective name by reader. "@ui5/webcomponents": "~1.24.0", & "@ui5/webcomponents-react": "~1.29.0"

Could you please try with below version? I have tried to downgrade version. but its not working. So could you please check with this version and inform me? "@ui5/webcomponents": "^1.14.0", & "@ui5/webcomponents-react": "^1.16.3"

MarcusNotheis commented 1 month ago

Hi @sanjayC5373903,

as I'm working on a Mac I can't reproduce the issue using JAWS, but here's the sandbox using the downgraded versions: https://stackblitz.com/edit/github-i6cvg6-gohsff?file=src%2FApp.tsx,package.json

Anyhow, as the issue seems to be fixed in the latest versions, I would strongly recommend to update to the latest 1.x release. The versions you're trying to reproduce the issue on are already more than one year old.

github-actions[bot] commented 1 month ago

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks.

sanjayC5373903 commented 1 month ago

Hi @MarcusNotheis I have tested as given using the downgraded versions. but its not working as expectation. we need read label. and also name of input field like "edit combo" and "edit input" .

MarcusNotheis commented 1 month ago

Does the issue occur on the latest v1 versions (@ui5/webcomponents: 1.24.8, @ui5/webcomponents-react: 1.29.7) as well? As mentioned before, the versions you are running on are more than a year old, so we won't downport changes to that version. You should be able to easily upgrade to the latest v1 versions as there are no breaking changes included.

github-actions[bot] commented 1 week ago

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks.

github-actions[bot] commented 5 days ago

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please first check to see if the maintainers have requested additional input and provide it if necessary, or post a detailed description of why this issue is still a problem.