SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
444 stars 99 forks source link

[DynamicPage]: the width style of header content div is not correct #6135

Closed GongRichard closed 3 months ago

GongRichard commented 3 months ago

Describe the bug

please don't set width 100% to the head content div of DynamicPage

Isolated Example

No response

Reproduction steps

  1. open page https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-dynamicpage--docs
  2. open dev tool to check the width of head content div
  3. you will find the div width of head content div is not correct

Expected Behaviour

remove width 100% setting

Screenshots or Videos

image

UI5 Web Components for React Version

1.29.5

UI5 Web Components Version

1.24.x

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP SuccessFactors

Declaration

ui5-webcomponents-react-bot commented 3 months ago

:tada: This issue has been resolved in version v1.29.6 :tada:

The release is available on v1.29.6

Your semantic-release bot :package::rocket:

sebastian-kraemer commented 3 months ago

@Lukas742 Isn't this breaking the fix for the other issue: https://github.com/SAP/ui5-webcomponents-react/issues/6087

Lukas742 commented 3 months ago

Hi @sebastian-kraemer

you're totally right, for some reason I didn't see that when looking at the GitHub change history for this line and thought it was a remnant of our v2 refactoring. Thanks a lot for noticing! I will investigate how this can be fixed for both scenarios and publish another version then.

ui5-webcomponents-react-bot commented 3 months ago

:tada: This issue has been resolved in version v1.29.7 :tada:

The release is available on v1.29.7

Your semantic-release bot :package::rocket:

Lukas742 commented 3 months ago

Hi @sebastian-kraemer

now the scrolling should work as intended again and also the header shouldn't overflow anymore. Sorry for the inconvenience.