Gantt Component

[23mluk]

Describe the solution you'd like Typical Gantt Component

[github-actions[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 30 days. Thanks.

[NPKompleet]

Hi @MarcusNotheis,

I will like to pick up this issue sometime in the next month if no one else is working on it yet. I just want to clarify if there is a specific set of features you want or if there are libraries you have in mind. Because I am thinking of a generic timeline chart that can serve as both a Gantt chart and also be used for other purposes.

Best regards.

[MarcusNotheis]

Hi @NPKompleet,

sorry for my late reply and thanks for offering to build this component! I've just assigned the issue to you 🙂

Regarding the basic features: I think the Gantt chart is a very complex component, so starting with the Timeline Chart sounds very good, we can then look into connecting it with a table for the final Gantt chart at a later point in time.

If you have any questions regarding our library setup, etc, always feel free to reach out :)

[NPKompleet]

Hi @MarcusNotheis,

A PR for this issue has been opened. https://github.com/SAP/ui5-webcomponents-react/pull/3921 Looking forward to the review.

Happy holidays.

[MarcusNotheis]

Thank you so much for your contribution, @NPKompleet 🙂 As we currently in the middle of the holiday season, the review of your PR might take a bit longer than usual.

Happy Holidays to you as well!

[NPKompleet]

Hi @Lukas742,

Happy New Year.

I have checked the cause of the failing test on my PR and it has to do with the rename of the TimeLineChart.tsx file to TimelineChart.tsx. Somehow the rename was not registered in the git index even though I added it. I have fixed it now with the git mv command and I have checked the changed files to confirm that it was reflected. Please, you can retrigger the pipeline again.

Thanks

[Lukas742]

I'm going to keep this issue open because although the TimelineChart created by @NPKompleet (thanks again) provides basic functionality for creating a Gantt chart, there are still many features we don't support.

[NPKompleet]

Hi @Lukas742,

I will be happy to keep contributing to this chart for the foreseeable future as long as I have the time for it. Please let me know what other features you will like to add to the chart or any other design decisions you may have and I will be happy to oblige. :)

[Lukas742]

Hi @NPKompleet

This is great, we really appreciate it. :)

Here you can find our global design for the Gantt Chart component. I think the next big step would be allowing basic user interactions by exposing events, preferably with equal or similar API as SAPUI5 is offering. Examples: https://ui5.sap.com//#/entity/sap.gantt.simple.GanttChartWithTable

[ui5-webcomponents-react-bot]

:tada: This issue has been resolved in version v1.10.0 :tada:

The release is available on v1.10.0

Your semantic-release bot :package::rocket:

[NPKompleet]

Hi @Lukas742,

I think I am liking the look of the the SAPUI5 Gantt chart. I tried to make the TimelineChart look as close as possible to the other recharts-based charts that existed already. But this Gantt Chart definitely looks a lot better and has even more functionalities that I did not consider.

Please let me know the specific user interactions you think are the most important and I can work on gradually integrating them in the future. Also, if we want to make the TimelineChart look exactly like the SAPUI5 Gantt chart, that is something I would be open to doing in the future too.

[Lukas742]

Hi @NPKompleet

I think for the start the "press" events of SAPUI5 would be a nice feature. Since all ui5-webcomponents have the naming convention for such events to be "click" instead of press, I think we should follow the approach here as well.

In general all "shape" events are features that should be included at some time. For this drag and drop needs to be enabled first though.

[NPKompleet]

Hi @Lukas742,

I have had a look at the press events for the Gantt Chart and the only "press" event I can see seems to be the shapePress event. I may be mistaken though.

[Lukas742]

Hi @NPKompleet

You're right, I wasn't clear enough on what I meant. I think the shapePress, shapeDoubleClick and maybe the shapeContextMenu events would be a good starting point.

Also shapeMouseEnter and shapeMouseLeave are probably pretty forward to implement.

Generally I don't have a hard opinion on what should be implemented first. If you think that other events are more important, then feel free to implement them first.