search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
450 stars 101 forks source link

Form: different label arrangement depending on the selected theme #6340

Closed saynesy closed 1 month ago

saynesy commented 2 months ago

Describe the bug

Depending on the selected theme, the position of the label changes, which makes the labelSpan property in Form non-functional.

I've noticed that for some themes, the --ui5-v2-1-2-form-item-layout CSS variable is not defined which may lead to such a problem.

Isolated Example

https://stackblitz.com/edit/github-jewrmx?file=src%2FApp.tsx

Reproduction steps

No response

Expected Behaviour

Have the same layout of items inside the form according to the given layout and labelSpan props in all themes.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.0.2

UI5 Web Components Version

2.1.2

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

MarcusNotheis commented 2 months ago

Hi @saynesy, thanks for reporting! I think this issue has already been fixed by the UI5 Web Components Team in https://github.com/SAP/ui5-webcomponents/pull/9800, but as far as I know this fix has not been released yet. I'll keep the issue open until the UI5 Web Components will ship their next release.

ui5-webcomponents-react-bot commented 1 month ago

:tada: This issue has been resolved in version v2.2.0 :tada:

The release is available on v2.2.0

Your semantic-release bot :package::rocket: