Closed Jianrong-Yu closed 1 month ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
packages/main/src/components/AnalyticalTable/hooks/useKeyboardNavigation.ts | 1 | 77.83% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 11502453799: | -0.02% |
Covered Lines: | 5052 |
Relevant Lines: | 5798 |
I fount the type for accessor
accessor?: string | ((row: RowType, rowIndex: number) => any);`
is also incorrect, it should be
accessor?: string | ((row: Record<string, any>, rowIndex: number) => any);
because in react-table
the accessor is called with the originalRow
if (column.accessor) {
row.values[column.id] = column.accessor(originalRow, rowIndex, row, parentRows, data);
} // Allow plugins to manipulate the column value
@Lukas742 Thanks for you suggestions, the code is modified now.
:tada: This PR is included in version v2.3.3 :tada:
The release is available on v2.3.3
Your semantic-release bot :package::rocket:
Fix #6519
Based on the code in
packages/main/src/components/AnalyticalTable/hooks/useSingleRowStateSelection.ts
, the type ofOnRowClickEvent
should beAnd the type
MouseEvent
should be changed toUIEvent
since the event can also be a Keyboard event based on the code: