search

SAP / ui5-webcomponents-react

A wrapper implementation for React of the UI5 Web Components that are compliant with the SAP Fiori User Experience
https://sap.github.io/ui5-webcomponents-react/
Apache License 2.0
444 stars 100 forks source link

Charts: warning coming from recharts pre 2.13 #6551

Closed perryd01 closed 2 weeks ago

perryd01 commented 3 weeks ago

Describe the bug

Having a chart component rendered will throw a warning/error in the console, but everything works fine. Updating recharts 2.13 might be a solution.

The warning:

XAxis: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

https://github.com/recharts/recharts/issues/3615#issuecomment-2407597181

Isolated Example

No response

Reproduction steps

No response

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.3.1

UI5 Web Components Version

2.3.0

Browser

Chrome

Operating System

macOS

Additional Context

No response

Relevant log output

No response

Organization

SAP GCID

Declaration

Lukas742 commented 3 weeks ago

Hi @perryd01

the linked PR fixes the warning, but the types aren't compatible with our current implementation. We didn't find the time yet to check why.

ui5-webcomponents-react-bot commented 2 weeks ago

:tada: This issue has been resolved in version v2.3.3 :tada:

The release is available on v2.3.3

Your semantic-release bot :package::rocket: