SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[SF][RatingIndicator]: [Rating Star should be able to be set size and some other issues] #10155

Open tandan0813 opened 1 week ago

tandan0813 commented 1 week ago

Describe the bug

  1. RatingIndicator component can't set size, while UI5 version can set; image

  2. In a display-only form, the half rating will show a hollow star style, while the Fiori doc shows a solid one and it seems more consistant. React: image Doc: image

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.4.0

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 1 week ago

Hi @tandan0813

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Regarding the size, please see this section of the component's description:

You can change the size of the Rating Indicator by changing its font-size CSS property.

Todor-ads commented 1 week ago

Hello @SAP/ui5-webcomponents-topic-rl, The mentioned issue with the half-empty star is reproducible in the playground . Could you please take a look? Regards, Todor