search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.58k stars 269 forks source link

fix(ui5-dialog): width on mobile is not bigger than the phone width #10199

Closed LidiyaGeorgieva closed 1 week ago

LidiyaGeorgieva commented 1 week ago

Issue: When the base font in the 'html' element is changed to something different than the default 16px (for example 32px) the width of the dialog can become larger than the width of the phone's display. This is caused by the 'min-width' (20rem) of the dialog. For the dialog on phone it is recommended by the design to set the dialog's property 'stretch' to true to use the full screen size.

The solution: When we have stretched dialog on phone the 'min-width' should not be applied (the width is 100%).

fixes: #10000

ui5-webcomponents-bot commented 5 days ago

:tada: This PR is included in version v2.5.0-rc.1 :tada:

The release is available on v2.5.0-rc.1

Your semantic-release bot :package::rocket: