SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.58k stars 271 forks source link

ui5-multi-input - show-suggestions property not working on 1.24.x #10265

Open amaillard-sap opened 1 week ago

amaillard-sap commented 1 week ago

Bug Description

Switching the 'show-suggestions' property to true, then false then true again does ont work as expected: the popover wont show again.

Affected Component

ui5-multi-input | ui5-suggestion-item

Expected Behaviour

The component always behaves properly based on show-suggestions property

Isolated Example

https://stackblitz.com/edit/js-bmmq59?file=index.js,package.json,index.html

Steps to Reproduce

1.open sample 2.type 's' in the multi input, see that suggestion popover is opened 3.click the toggle button (this switches show suggestions to false) > see that the popover closes and cannot be brought back 4.click the toggle button (this switches show suggestions to true - check in the DOM that show-suggestions attribute is present)

the suggestion popover will never be displayed again

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.13

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP SBPA

Declaration

s-todorova commented 6 days ago

Hello @SAP/ui5-webcomponents-topic-rl,

The issue is reproducible in the example above as well as in the playground for v1.x of ui5-webc. Could you please take a look at this?

Best regards, Siyana

amaillard-sap commented 6 days ago

note that this works fine in v2.x (tested on latest only)