search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.55k stars 266 forks source link

ui5-messagestrip: maybe error for information type color #1496

Closed alex-zhang closed 4 years ago

alex-zhang commented 4 years ago

hi,

I am from Web Experience team in SAP Successfactors.

Describe the bug

ui5-messagestrip: Error Background Color for Information.

As the wiki describe: https://wiki.wdf.sap.corp/wiki/pages/viewpage.action?pageId=2036840833#MessageStrip(Fiori3)-Semanticvariations

Information Background: @sapUiInformationBGBorder Border: @sapUiInformationBorder Icon: @sapUiInformativeElement

It's should be looks like below

image

Not this one

image

But i also find the fiori link https://experience.sap.com/fiori-design-web/message-strip, it's seems it's correct in ui5-webcomponent. but the fiori expert told me, follow the wiki. pls help me to confirm that, thanks.

ilhan007 commented 4 years ago

Hello @alex-zhang

according to the latest design for Quartz Light theme (Fiori 3) our Information type has wrong background color, it should look like as on your first image and we prepared a fix for that. It will be merged in the next few days. Also, we found that the colors of the icons in the beginning of the message strip are wrong, they should not be grey, but in the respective semantic color.

You can look at the fix here: https://github.com/SAP/ui5-webcomponents/pull/1498

best, ilhan

alex-zhang commented 4 years ago

That's great. And thanks for ur quick reply.