SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

ui5-popover will move 1px after first time open up #1755

Closed GongRichard closed 3 years ago

GongRichard commented 4 years ago

Hi colleague, I am from SAP SuccessFactors team. Please help to take a look at this issue.

Describe the bug In compact mode, some Status Drop Down popover and Action popover will move about 1px after the first time open up. This issue can only be reproduced in compact mode.

To reproduce Steps to reproduce the behavior:

  1. Go to GoalCardContainer
  2. Click More Actions button on the top right of Card
  3. Click Status Drop Down button on the bottom left of Card

Isolated example PopoverMove

Expected behavior Popover shouldn't move after open up.

Context

vladitasev commented 4 years ago

Hello @GongRichard ,

I was unable to reproduce the issue with our latest version on our test pages. I notice you're using an old version: RC7 https://github.wdf.sap.corp/xweb/goalmanagementx/blob/master/package.json

Maybe that's the problem? There is a much newer version, maintained specifically for SFSF 0.21.1 (soon we'll release 0.21.2).

Could you try migrating to: "@ui5/webcomponents": "0.21"

Regards, Vladi

GongRichard commented 4 years ago

Hi @vladitasev ,

Yes, I have tried 0.21 in my local. This issue can't be reproduced. I am closing this ticket.

Thanks, Richard

GongRichard commented 4 years ago

Hi @vladitasev ,

This issue shows again, we use wc version 0.21.10. You can check page https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-content-density=compact#/goal-list?templateType=tgm&templateId=22 to reproduce.

Thanks, Richard

GongRichard commented 4 years ago

Hi @ilhan007 and @vladitasev,

Would you please take a look at this issue first as we need to release our product next week?

Thanks, Richard

ilhan007 commented 3 years ago

Hello @GongRichard is it still reproducible with 0.27.3? Should we use the same URL to check the issue: https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-content-density=compact#/goal-list?templateType=tgm&templateId=22

Does it use the latest SFSF version?

GongRichard commented 3 years ago

Hi @ilhan007,

This issue still is reproducible with 0.27.3, you can use the same URL to check the issue. https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-content-density=compact#/goal-list?templateType=tgm&templateId=22 The version of that page is 0.27.3.

Thanks, Richard

ilhan007 commented 3 years ago

Hello @SAP/ui5-webcomponents-topic-rd please have a look into this issue.

BR, ilhan