search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

ui5-input: [a11y] customized valueStateMessage from slot is not read correctly #2106

Closed zhangliangyi closed 4 years ago

zhangliangyi commented 4 years ago

Dear colleague,

I am from Successfactors web experience Shanghai team.

Describe the bug In NVDA screen reader, the customized valueStateMessage is not correctly read.

In error state, the output from screen reader is always Invalid entry. In warning state, the output is Warning issued.

To reproduce Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Input/
  2. Move the section Input with Suggestions and Value State message
  3. Focus to the second input field and check the screen reader output

Expected behavior Screen reader should output the customized valueStateMessage, "This is an error message. Extra long text used as an error message."

Context

Other user input components have the same issue, such as ui5-textarea and ui5-datepicker

Thanks Jacob

ilhan007 commented 4 years ago

The PR (https://github.com/SAP/ui5-webcomponents/pull/2120) addresses the ui5-input and ui5-datepicker components.

ilhan007 commented 4 years ago

The PR (https://github.com/SAP/ui5-webcomponents/pull/2122) fixes the ui5-textarea