search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[BUG][A11Y][Select] Accessibility Issue #2190

Closed Hubery-Shen closed 4 years ago

Hubery-Shen commented 4 years ago

Dear colleagues, I am from SuccessFactors Web Experience Shanghai team.

Lose many a11y attributes:

  1. aria-roledescription
  2. aria-disabled
  3. aria-readonly
  4. aria-expanded
  5. aria-controls
  6. aria-activedescendant
  7. aria-selected
  8. aria-setsize
  9. aria-posinset
BUG select-3 BUG Select-1
fifoosid commented 4 years ago

Hello @Hubery-Shen

I am merging a PR, fixing this issue. However, after a sync with our ACC experts we reached the following conclusion(More info here):

aria-roledescription - added aria-disabled - already implemented aria-readonly - not needed, as the select doesn't have readonly property aria-expanded - added aria-controls - not needed, because we have a aria-haspopup=listbox aria-activedescendant - could not be implemented since the items are in a different DOM aria-selected - added aria-setsize - added aria-posinset - added

BR, Filip

Milo-Shen commented 4 years ago

Hi @fifoosid

Thanks for your support