search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

ui5-wizard: Navigation area selected step may be incorrect on step change #2876

Closed todormikov closed 3 years ago

todormikov commented 3 years ago

Describe the bug When moving to a step by setting its 'selected' property to true, the step highlighted in the navigation area of the wizard may be incorrect.

To reproduce Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Wizard/
  2. Click the Step 2 button in the sample Wizard
  3. Toggle the 5 years guarantee included button to make the Step 3 button appear
  4. Click the Step 3 button
  5. The wizard will scroll to the third step, but the second step will be selected in the navigation area
  6. Click the Medium button to make the Step 4 button appear
  7. Click the Step 4 button
  8. The wizard will scroll to the fourth step, but the third step will be selected in the navigation area

Isolated example https://sap.github.io/ui5-webcomponents/playground/components/Wizard/

Expected behavior When going to a step by setting its 'selected' property to true, the navigation area of the wizard should display the correct step as selected

Context

Affected components Wizard

TeodorTaushanov commented 3 years ago

Hello @SAP/ui5-webcomponents-topic-rl,

I'm able to reproduce the issue on a small screen size and there is a scrollbar inside the Wizard content.

ilhan007 commented 3 years ago

Hello @todormikov

I used Chrome, but did not catch the described issue. Did I perform the steps correctly?

https://user-images.githubusercontent.com/15702139/109517251-b89c8e80-7ab1-11eb-912d-f48ad8a14e56.mov

todormikov commented 3 years ago

Hello @ilhan007 You performed the steps correctly. My guess is that the issue might only be present on Windows, since I couldn't reproduce it on Linux. I have not tested Mac.

This is how it behaves on Chrome in Windows:

https://user-images.githubusercontent.com/79699783/109956634-8b87f000-7cec-11eb-99c3-097fe35223ba.mp4

ilhan007 commented 3 years ago

I will ask someone from the team that has Windows to test it as well, thanks for the video.

ilhan007 commented 3 years ago

Hello @unazko can you check the issue. I could not reproduce it with Mac + Chrome, according to the author it might happen only on Windows + Chrome. here are videos attached for both setups (Mac + Chrome and Windows + Chrome) that illustrates the behaviour.

If you are able to reproduce it, please forward it to @SAP/ui5-webcomponents-topic-rl for further investigation.

todormikov commented 3 years ago

I checked today and could not reproduce the error on Chrome or Edge. I suppose this issue was resolved by another fix in the webcomponents or those browsers.