search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

[ui5-table] input field does not accept SPACE when becomes a child of ui5-table-cell #3436

Closed randolf-alegre closed 3 years ago

randolf-alegre commented 3 years ago

Input field does not accept SPACE when place within the ui5-table-cell web component. When you start typing and press the space bar space is not displayed. To double-check the value, inspect the input element and see the value attribute.

Expected Behavior: Input field should accept SPACE.

Steps to Reproduce:

  1. Create a new ui5-table element.
  2. add ui5-table-column.
  3. add ui5-table-row.
  4. Within the ui5-table-row, add ui5-table-cell.
  5. Within the ui5-table-cell add a ui5-input element.
  6. Start typing on the input field.

Sample: https://codesandbox.io/s/practical-villani-s6w4f?file=/index.html

Context

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

georgimkv commented 3 years ago

Hi @randolf-alegre We recently had an issue for the same use case - #3390, which is already fixed, so you will be able to consume the fix in the next release of the library! Thanks for reporting the issue. Regards, Georgi

kotmiilawrence commented 3 years ago

Hi @gmkv The issue still persists when nested ui5-input element under ui5-table and ui5-table-row. I believe is due to the keydown handler under TableRow.js is still preventing space entry.

georgimkv commented 3 years ago

Hi @SAP/ui5-webcomponents-topic-rl Could you take a look at this issue with the input inside a table row?

Regards, Georgi

georgimkv commented 3 years ago

@kotmiilawrence I believe this issue persists because the new version of the library hasn't been released yet.

niyap commented 3 years ago

Hello @randolf-alegre,

Thanks for sharing your findings!

As Georgi has mentioned, the issue is already reported #3390 and fixed with the following change https://github.com/SAP/ui5-webcomponents/pull/3393

Please, wait for the next release and check again.

Kind Regards, Niya