search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 260 forks source link

[URGENT][BUG][UI5-Table][UI5-List][Badge]Inner ui5-hidden-text element will result the error rendering of ui5-table, ui5-list in RTL mode #3503

Closed sfsf-xweb-sh closed 3 years ago

sfsf-xweb-sh commented 3 years ago

Dear colleagues, I am from SuccessFactors Web Experience Shanghai team.

Bug Description: Inner ui5-hidden-text element in Badge and ui5-li-groupheader will lead to the error rendering of ui5-table and ui5-list component in RTL mode. ui5-table and ui5-list will render the unnecessary scroll bar in RTL mode

Expected Behavior: ui5-table and ui5-list will not render the unnecessary scroll bar in RTL mode

Reproduce step:

  1. goto https://github.wdf.sap.corp/pages/xweb/assignment/app.html?mock&sap-ui-rtl=true#/assignment-detail/ao/2
  2. switch to Applicants panel
  3. this website contains the source map

Screen Shot 2021-07-14 at 5 30 34 PM

Screen Shot 2021-07-14 at 1 30 52 PM

vladitasev commented 3 years ago

Hello @sfsf-xweb-sh

Just opened the page and I can see no horizontal scrollbar: image

I tried resizing or opening on phone, still I get no horizontal scrollbar.

Regards, Vladi

alexandar-mitsev commented 3 years ago

Hi @SAP/ui5-webcomponents-team ,

I could reproduce the issue on Chrome on Windows. The scroll really seems to appear because of the ui5-hidden-text styles. Specifically the left: -1000px. If replaced with right: -1000px for rtl the scroll is gone.

Regards, Alex

sfsf-xweb-sh commented 3 years ago

Hi @vladitasev @alexandar-mitsev

You can reproduce this bug on chrome

Regards, XWeb Shanghai team

ilhan007 commented 2 years ago

Fixed with 0.31.18