SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

List component: When the list prop 'mode' is set to 'MultiSelect', on accessing the list items, the corresponding list title and the state ‘Selected’ is not read. #3707

Closed kolew96 closed 2 years ago

kolew96 commented 3 years ago

Describe the bug When the list prop 'mode' is set to 'MultiSelect', on accessing the list items, the corresponding list title, item level of level count information and the state ‘Selected’ is not read.

To Reproduce Steps to reproduce the behavior:

  1. Set the list prop 'mode' to 'MultiSelect'
  2. Turn on the Narrator
  3. Try to navigate to the any list item above level 1

Observed behavior On accessing StandartListItem from a List, when list mode is set to multiselect, navigation focus the StandartListItem's button first, then after pressing Arrow down key, the StandartListItem's children text is read only

Expected behavior On accessing StandartListItem from a List, when list mode is set to MultiSelect, navigation should focus the whole StandartListItem's and give the information about the corresponding list header, item level, item title, and state of UI (selected or not).

UI5 Web Components for React Information @ui5/webcomponents version: @ui5/webcomponents-react version: v0.15.3

Context Browser (if relevant): {...} Chrome

Additional context Label association issue, state of UI not read --removed--

Lukas742 commented 3 years ago

Hi @kolew96

I removed the "additional context" link as it was showing details which I think should not be made public, even if they only work in our internal system. If this is not a problem, feel free to add the link again. Better safe than sorry ;)

As for the issue, I will forward it to the UI5 Web Components repo, since the List component is developed by our colleagues there.

unazko commented 3 years ago

Hello @kolew96,

Could you please edit the following snipped: https://codesandbox.io/s/strange-davinci-boc66?file=/src/index.js so we could reproduce the issue.

Thank you, Boyan

dimitar-trendafilov commented 3 years ago

Hello @unazko

https://codesandbox.io/s/currying-frost-fl0ys?file=/src/App.js

Here, this is edited snipped. Hope this helps.

BR, Dimitar

ilhan007 commented 3 years ago

Hello @dimitar-trendafilov now @terezamch is the issue dispatcher from our side. @terezamch could you please process the issue.

BR, ilhan

terezamch commented 3 years ago

Hello @kolew96 and @dimitar-trendafilov,

I have tested the scenario in the given example and in an isolated from React one - with ui5-list - https://codesandbox.io/s/headless-fog-pb0js?file=/index.html

I can distinguish only one concern - when a selected item is focused, the reader is not announcing that it is selected. For unselected items, the reader is stating that they are not selected. Could you please confirm that this is the thing that you are reporting?

Thanks, Tereza

ilhan007 commented 3 years ago

Hello @dimitar-trendafilov could you take a look of the previous comment by @terezamch so we can continue processing the issue?

dimitar-trendafilov commented 3 years ago

Hi @terezamch

Yes, this is exactly the behavior which I have observed.

ilhan007 commented 3 years ago

Hello @SAP/ui5-webcomponents-topic-p could please take over?

The selected state of the List Item is not announced by the screen reader. Although the author did not mentioned which tool has been used, the dispatcher from our side has tested the isolated example https://codesandbox.io/s/headless-fog-pb0js?file=/index.html and confirmed the issue, so I guess it is reproducible with Jaws.

BR, ilhan

nnaydenow commented 3 years ago

Hi @kolew96,

Could you please share which version of the project you are currently using?

Seems that the problem is fixed with #3952 and the fix will be available with the next version.

BR, Nayden

ilhan007 commented 3 years ago

Hi @nnaydenow they are using older version - RC.15.

ilhan007 commented 3 years ago

Hello @kolew96 could you retest using an updated version of the reproducible sample https://codesandbox.io/s/magical-smoke-uqndt

The sample now loads the very latest development.

ilhan007 commented 2 years ago

Hello @kolew96 closing the issue due to inactivity. Feel free to provide more input as requested and we will re-open the issue.