search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

3rd applications can navigate outside of Dialog. #4001

Closed lormanlau closed 2 years ago

lormanlau commented 3 years ago

Bug Description

A clear and concise description of what the bug is. When using a screen reader / 3rd party application, user is able to navigate outside the dialog area.

Expected Behavior

A clear and concise description of what you expect to happen. User should only stay inside of the dialog box. https://sapui5.hana.ondemand.com/sdk/#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog does not have this issue.

Steps to Reproduce

  1. Launch JAWS 2020
  2. Launch a UI5 Web Components Dialog from https://sap.github.io/ui5-webcomponents/playground/components/Dialog/
  3. Click on the heading of the dialog
  4. Press the H key, for navigating to headings a few times and then tab.
  5. Observe that you are able to focus outside the Dialog.

Isolated Example

https://sap.github.io/ui5-webcomponents/playground/components/Dialog/

Context

Log Output / Stack Trace / Screenshots

Screen Shot 2021-09-24 at 2 05 11 PM

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

Todor-ads commented 3 years ago

Hello @lormanlau, Thank you for sharing this finding. Can you check if this problem persist? I tried to reproduce it, but I failed. It is not possible to focus anything outside of Dialog. Regards, Todor

lormanlau commented 3 years ago

Hi @Todor-ads this problem still persists, using Insert + F6 (list all headings) can also take you out of the dialog.

ilhan007 commented 2 years ago

Hello @lormanlau can you try with the latest version, notice the "master" in the path of the URL:

https://sap.github.io/ui5-webcomponents/master/playground/components/Dialog/

TeodorTaushanov commented 2 years ago

Hi,

This is not a valid condition when JAWS (or any other screen reader) is used, as there is no mouse click in that case.

Best, Teo