ui5-popover: issue found during exploratory mobile testing iOS

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.51k stars 260 forks source link

ui5-popover: issue found during exploratory mobile testing iOS #4206

Open kskondov opened 2 years ago

kskondov commented 2 years ago

Bug Description

1) Email input is cut off on the right and a scroll appears 2) Focus not visible on the left

Steps to Reproduce

On iOS device go to https://sap.github.io/ui5-webcomponents/master/playground/components/Popover/
On iOS device go to https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Popover/ and open modal popover

Context

UI5 Web Components version: master

Log Output / Stack Trace / Screenshots

Priority

[ ] Low
[x] Medium
[ ] High
[ ] Very High

kskondov commented 2 years ago

The issue is reproducible on specific devices: iPhone 12 Pro and iPhone 13

dimovpetar commented 2 years ago

Fix for the sample issue: #4527 Fix for the focus: to do

dimovpetar commented 2 years ago

Hello colleagues,

The remaining part of this issue is about the focus border of list items on mobile devices. It is cut from the sides. I think it should not be shown at all on mobile devices. To reproduce it open https://sap.github.io/ui5-webcomponents/playground/components/List/ and focus any item. I have tested on iPhone. Can you please check?

Best regards, Petar